Automattic/node-canvas

fillStyle and strokeStyle fail when using fractional values on rgba

Open

#1,787 创建于 2021年4月19日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)JavaScript (9,524 star) (1,140 fork)batch import
BugGood first issue

描述

Issue or Feature

Whenever you try to set a color style with fractional components like 'rgba(120.1, 120.2, 120.3, 1)', it fails to parse and defaults to a black color.

Steps to Reproduce

var Canvas = require('canvas');
var canvas = Canvas.createCanvas(200, 200);
var ctx = canvas.getContext('2d');
ctx.fillStyle = 'rgba(240.2,0,0,1)';
ctx.fillRect(20, 20, 40, 40);

Shows a black rectangle instead of a red one.

Your Environment

node-canvas 2.7.0 Node is v12.16.1 on OS X Catalina 10.15.7

贡献者指南

技术栈
javascriptc
领域
backendtooling
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
basic JavaScriptfamiliarity with Node.js native modulesunderstanding of CSS color parsing
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
The bug is in the native color parsing code, likely in 'src/color.cc' or similar. The parsing of 'rgba()' currently fails when color components have decimal points. To fix, update the regular expression or parsing logic to accept fractional values like 'rgba(120.1, 120.2, 120.3, 1)'. Check the existing test suite in 'test/' for related color tests and add a test case for fractional rgba. Ensure the fix handles both 'rgba' and 'hsla' consistently if needed.