AppImage/AppImageKit

appimagetool follows symlinks outside of the AppImage for determining architecture

Open

#546 创建于 2017年11月26日

在 GitHub 查看
 (4 评论) (0 反应) (0 负责人)C (8,239 star) (547 fork)batch import
buggood first issue

描述

/home/me/squashfs-root/opt/cxoffice/support/apps.com.qq.im.light/dosdevices/f:/boot/grub/x86_64-efi/test.mod used for determining architecture x86_64
/home/me/squashfs-root/opt/cxoffice/support/apps.com.qq.im.light/dosdevices/f:/boot/grub/x86_64-efi/lspci.mod used for determining architecture x86_64
/home/me/squashfs-root/opt/cxoffice/support/apps.com.qq.im.light/dosdevices/f:/boot/grub/x86_64-efi/usb_keyboard.mod used for determining architecture x86_64
/home/me/squashfs-root/opt/cxoffice/support/apps.com.qq.im.light/dosdevices/f:/boot/grub/x86_64-efi/hexdump.mod used for determining architecture x86_64
/home/me/squashfs-root/opt/cxoffice/support/apps.com.qq.im.light/dosdevices/f:/boot/grub/x86_64-efi/true.mod used for determining architecture x86_64
/home/me/squashfs-root/opt/cxoffice/support/apps.com.qq.im.light/dosdevices/f:/boot/grub/x86_64-efi/usbserial_common.mod used for determining architecture x86_64

@teras when packaging an AppImage that contains a WINEPREFIX which links outside of the AppImage, then it tries to determine architectures outside of the AppImage.

It should not follow symlinks to determine the architecture, let alone symlinks that point to the outside of the AppImage.

贡献者指南

技术栈
c
领域
desktoptooling
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
C programmingunderstanding of symlinksfamiliarity with AppImage tooling
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
40
研究方向
The issue is in appimagetool's architecture detection logic. The tool currently reads ELF files to determine architecture but follows symlinks, including those pointing outside the AppImage. The fix should ensure that symlinks are not followed when scanning for ELF files. Look in the appimagetool source code (likely in src/ or similar) for functions that traverse the filesystem to find ELF files. Modify them to skip symlinks or to not follow them. Check existing comments or linked PRs for additional context.