AllenFang/react-bootstrap-table

Extend filters to allow html attributes to be passed down

Open

#1,715 创建于 2017年10月26日

在 GitHub 查看
 (1 评论) (0 反应) (0 负责人)JavaScript (2,240 star) (795 fork)batch import
help wantedin progress

描述

Hello. Currently it appears there is no way to add an html attribute to the underlying markup that is generated by the built-in filters such as <SelectFilter>.

My use-case would be adding an id, data, or aria attribute to the html elements such as a <select>.

Attributes are passed to the component in the JSX. https://github.com/AllenFang/react-bootstrap-table/blob/281db991c08f1d4cad2c522b13875a97d2e27e0f/src/TableHeaderColumn.js#L70

But they aren't shared with the HTML elements. https://github.com/AllenFang/react-bootstrap-table/blob/281db991c08f1d4cad2c522b13875a97d2e27e0f/src/filters/Select.js#L98-L104

I'm happy to submit a PR if you agree with the use.

贡献者指南

技术栈
javascriptreact
领域
frontendaccessibility
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Basic ReactProps passing in React
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
80
研究方向
Investigate the source files: src/TableHeaderColumn.js and src/filters/Select.js. In Select.js, the component currently renders a <select> element with specific props; add a prop like `htmlAttributes` or simply spread additional props onto the <select>. Ensure that tests are updated. Also check if similar filters need the same treatment. Since the author offered a PR, coordinate with maintainers for guidance.