AdguardTeam/AdGuardHome

Rewrite networking in package dhcpd to only use gopacket

Open

#4,923 创建于 2022年9月15日

在 GitHub 查看
 (0 评论) (1 反应) (1 负责人)Go (34,000 star) (2,333 fork)batch import
P3: Mediumenhancementexternal libshelp wantedresearch

描述

Prerequisites

  • I have checked the Wiki and Discussions and found no answer

  • I have searched other issues and found no duplicates

  • I want to request a feature or enhancement and not ask a question

Description

What problem are you trying to solve?

Package dhcpd currently uses a lot of different modules and packages for networking, including github.com/google/gopacket, github.com/insomniacslk/dhcp, github.com/mdlayher/ethernet, and the deprecated github.com/mdlayher/raw. This creates all sorts of issues, including but not limited to:

  1. portability;
  2. API compatibility;
  3. difficulty of package update and maintenance.

Proposed solution

Module github.com/google/gopacket seems to have either all or most of the things we require. If I am not mistaken, we could even enable DHCP on Windows, if we make sure that the networking works well there.

Alternatives considered

Go on as we do. See the problems with this approach above.

贡献者指南

技术栈
go
领域
backend
议题类型
refactor
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
4
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
over 1 week
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Gonetworking fundamentalsgopacket libraryAdGuardHome DHCP module
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
20
研究方向
Examine the current networking code in the 'dhcpd' package to identify all usages of 'github.com/insomniacslk/dhcp', 'github.com/mdlayher/ethernet', and 'github.com/mdlayher/raw'. Then, research how to replace each with 'github.com/google/gopacket' equivalents. Pay special attention to Windows compatibility as mentioned in the issue. Since the issue is assigned, it may be worth checking the assignee's progress or discussing with maintainers to avoid duplication.