AbsaOSS/enceladus

Refactor Validation Utils

开放

#57 创建于 2018年12月2日

 (1 条评论) (0 个反应) (0 位负责人)Scala (16 个派生)auto 404
Conformancegood first issuepriority: undecidedrefactoring

仓库指标

星标
 (33 个星标)
PR 合并指标
 (PR 指标待抓取)

描述

We have two separate ValidationExceptions:

  • za.co.absa.enceladus.conformance.interpreter.rules.ValidationException (only used in Standardization)
  • za.co.absa.enceladus.utils.validation.ValidationException (only used in Conformance) Conformance also dips into za.co.absa.enceladus.utils.validation.ValidationUtils before throwing its own ValidationException, which blurs the line between which ValidationException is responsible for what.

Good design dictates a clear separation between the two or a unification.

There is also some code duplication in conformance rules, specifically aimed at validation, that would best be extracted to a common location.

贡献者指南