zulip/zulip

limited guests: Optimize get_recipients_for_user_creation_events

Open

#27,835 建立於 2023年11月22日

在 GitHub 查看
 (3 留言) (0 反應) (1 負責人)Python (19,672 star) (7,339 fork)batch import
area: performancearea: settings (user groups)help wantedin progress

描述

In #27544, whenever a limited guest tries to send a DM to another user, we end up doing a fairly expensive get_accessible_user_ids check, as noted in https://github.com/zulip/zulip/pull/27544#discussion_r1401550500.

Ideally, we'd not do that. I think the best solution might start with #25713, which would allow us to start by checking if we have an existing Huddle object, and if so, skip doing any further authorization check; that would change this from an "every DM" performance issue, which might result in annoying latency, to a "First DM in a new Huddle" one.

But since #25713 might take some time to get organized for, it might make sense to look at just optimizing the queries to filter to the set of relevant users; that'll still be useful even if we do that too.

貢獻者指南

技術棧
pythondjangosql
領域
backendperformance
議題類型
performance
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
4
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
3-5 days
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
active
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
Django ORMZulip permissions model
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
30
研究方向
Start by reading the discussion in pull request #27544, especially the comment at https://github.com/zulip/zulip/pull/27544#discussion r1401550500 about the expensive get accessible user ids check. Understand the current implementation of get recipients for user creation events and how Huddle objects are used. Consider two approaches: first, implementing #25713 to skip authorization checks for existing Huddles, or second, optimizing the query to filter only relevant users. Look at the Django ORM queries involved and test potential optimizations locally.