zulip/zulip

Forwarding an email containing `@all` to the email gateway drops the email with an error.

Open

#19,655 建立於 2021年9月1日

在 GitHub 查看
 (8 留言) (0 反應) (0 負責人)Python (19,672 star) (7,339 fork)batch import
area: emailsarea: markdown (mentions)bughelp wanted

描述

The email gateway doesn't have permissions to use @all (or @stream or @everyone) and so attempts to send messages containing those characters fails.

We should escape those characters, or at least make this not a logged exception.

Sentry Issue: ZULIP-RZ

JsonableError: You do not have permission to use wildcard mentions in this stream.
  File "zerver/lib/actions.py", line 3396, in _internal_prep_message
    email_gateway=email_gateway,
  File "zerver/lib/actions.py", line 3357, in check_message
    _("You do not have permission to use wildcard mentions in this stream.")

Error queueing internal message by emailgateway@zulip.com: You do not have permission to use wildcard mentions in this stream.

貢獻者指南

技術棧
pythondjango
領域
backend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
PythonZulip email gatewaywildcard mentions
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
70
研究方向
The issue is in `zerver/lib/actions.py` where ` internal prep message` raises a `JsonableError` for wildcard mentions. The fix should either escape `@all`, `@stream`, `@everyone` characters in the email gateway or change the behavior to not throw an exception. Check the linked Sentry issue and the comment discussing using `@**all**` syntax. Look at how the email gateway processes messages in `zerver/lib/email mirror.py` and related tests.