zsh-users/zsh-syntax-highlighting

Block with assignment with no command

Open

#854 建立於 2022年1月31日

在 GitHub 查看
 (2 留言) (0 反應) (0 負責人)Shell (22,617 star) (1,371 fork)batch import
Buggood first issue

描述

% tests/generate.zsh '{ a=42 }' main block-assignment-no-command
Set copyright year to 2022? y
BUFFER=$'{ a=42 }'

expected_region_highlight=(
  '1 1 reserved-word' # {
  '3 6 assign' # a=42
  '5 6 default' # 42
  '8 8 unknown-token' # }
)

That's a valid command so the final } should be a reserved-word.

貢獻者指南

技術棧
shell
領域
tooling
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
zsh syntaxtesting with zsh syntax highlighting
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
70
研究方向
The issue describes a case where an assignment inside a block (e.g., `{ a=42 }`) is incorrectly highlighted: the closing brace `}` is marked as `unknown token` instead of `reserved word`. To fix, examine the syntax highlighting logic in the repository, likely in files like `highlighters/main/main highlighter.zsh`. The test file `tests/generate.zsh` shows the expected output. Modify the highlighting rules to recognize that assignment with no command is valid in a block, making the `}` a reserved word. Confirm the fix by running the test suite.