zsh-users/zsh-syntax-highlighting

$READNULLCMD / $NULLCMD are red

Open

#716 建立於 2020年3月23日

在 GitHub 查看
 (0 留言) (0 反應) (0 負責人)Shell (22,617 star) (1,371 fork)batch import
BugTaskgood first issuesyntax:command-word

描述

% tests/generate.zsh '$NULLCMD | $READNULLCMD' main nullcmd 'local NULLCMD=cat READNULLCMD=f; f(){};' 
Set copyright year to 2020? y
local NULLCMD=cat READNULLCMD=f; f(){};

BUFFER=$'$NULLCMD | $READNULLCMD'

expected_region_highlight=(
  '1 8 unknown-token' # $NULLCMD
  '10 10 commandseparator' # |
  '12 23 unknown-token' # $READNULLCMD
)

That's likely because they're special, and as such don't get expanded (which makes this another case of #695):

% p ${(t)READNULLCMD} ${(t)NULLCMD}
scalar-special scalar-special

貢獻者指南

技術棧
shell
領域
developer experiencecli
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
basic zsh knowledgegitshell scripting
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
30
研究方向
Investigate how $NULLCMD and $READNULLCMD are handled in the highlighting code (likely in 'highlighters/main/main highlight.zsh'). The issue notes they have the 'special' attribute, which prevents expansion. See reference to issue #695 for similar cases. The fix likely involves adding them to a list of variables that should be expanded despite being special. Look for where other special variables are expanded and replicate for these two.