zsh-users/zsh-syntax-highlighting

PATH_DIRS shouldn't be honoured after `sudo`

Open

#595 建立於 2018年12月24日

在 GitHub 查看
 (0 留言) (0 反應) (0 負責人)Shell (22,617 star) (1,371 fork)batch import
Buggood first issuesyntax:command-word

描述

The main highlighter explicitly sets PATH_DIRS if the user has that enabled:

https://github.com/zsh-users/zsh-syntax-highlighting/blob/55f846c673661bde03ef97333be7889f54079c7b/highlighters/main/main-highlighter.zsh#L316-L318

This is so, if $^path/foo/bar(*N) exists, % foo/bar will be highlighted in green. However, that also happens in sudo foo/bar, even though sudo doesn't do path searches when there's a / in the argument — at least, I think that's how sudo behaves, but double-check that before making any code change on our end.

貢獻者指南

技術棧
shell
領域
clideveloper experience
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
zsh shellsudo behaviorzsh syntax highlighting codebase
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
50
研究方向
Investigate sudo behavior: confirm whether sudo performs path searches when the argument contains a slash (likely not). Then modify main highlighter.zsh around line 316-318 to skip setting PATH DIRS for commands like sudo. The fix is localized and should be straightforward.