zephyrproject-rtos/zephyr

Bluetooth: Audio: Add checks for bt_conn_ref return value where applicable

Open

#95,148 建立於 2025年8月29日

在 GitHub 查看
 (1 留言) (0 反應) (2 負責人)C (15,249 star) (9,144 fork)batch import
EnhancementGood first issuearea: Bluetootharea: Bluetooth Audio

描述

Summary

If the connection pointer supplied to an API call is not connected (e.g. if the application has cached it incorrectly), then when we perform a bt_conn_ref in the LE Audio code to take a reference, it can return NULL, which indicates a non-connected bt_conn pointer.

Describe the solution you'd like

For each call of bt_conn_ref in LE Audio from a struct bt_conn * from the higher layers, we need to verify that the return value is non-NULL.

Alternatives

Alternatively, we should check early in the function if the struct bt_conn is in the connected state. If a user attempts to perform any operation that expects the connection to be connected, and it is not, then we should return early to avoid unncessary memory copies etc. to generate the PDUs.

No response

Additional Context

This may also be an issue in other non-LE Audio places.

貢獻者指南

技術棧
c
領域
security
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
blocked
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
C programmingPointer managementBluetooth LE Audio concepts
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
40
研究方向
Locate all calls to bt conn ref in the LE Audio subsystem (likely under subsys/bluetooth/audio/). For each call, verify if the return value is checked for NULL and add a null check with an early return or appropriate error handling. Consider also adding a state check on the bt conn pointer to confirm it is connected, as suggested in the issue. Look at existing implementations in other Bluetooth profiles (e.g., HFP, A2DP) for patterns of reference counting and error handling. Since this issue has assignees, it is recommended to coordinate or check if any work is already in progress.