zephyrproject-rtos/zephyr

Bluetooth: Controller: Use defines for access_addr and crc_init array sizes

Open

#40,378 建立於 2021年11月16日

在 GitHub 查看
 (2 留言) (0 反應) (1 負責人)C (15,249 star) (9,144 fork)batch import
EnhancementGood first issuearea: Bluetootharea: Bluetooth Controller

描述

Is your enhancement proposal related to a problem? Please describe. access_addr always seems to be of size 4; that should be #defined. crc_init always seem to be of size 3; that should be #defined.

https://github.com/zephyrproject-rtos/zephyr/pull/31009/files#r736229677 https://github.com/zephyrproject-rtos/zephyr/pull/31009/files#r736229386

Describe the solution you'd like A clear and concise description of what you want to happen.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context Add any other context or graphics (drag-and-drop an image) about the feature request here.

貢獻者指南

技術棧
c
領域
backend
議題類型
refactor
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
blocked
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
C programmingZephyr RTOS basicsBluetooth controller conceptsGit and PR workflow
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
70
研究方向
Examine the linked PR #31009 at the specific comment lines to identify where hardcoded array sizes appear for access addr and crc init. Then, define macros for those sizes (e.g., BT CTLR ACCESS ADDR SIZE and BT CTLR CRC INIT SIZE) and replace the hardcoded values throughout the Bluetooth controller code. The changes should be isolated to the controller module. Verify that no other occurrences exist in the codebase.