zenoamaro/react-quill

False positive "You are passing the delta object from the onChange event back as value"

Open

#498 建立於 2019年7月8日

在 GitHub 查看
 (6 留言) (7 反應) (0 負責人)JavaScript (6,238 star) (860 fork)batch import
good first issuehelp wanted

描述

In my case, when both nextContents and this.lastDeltaChangeSet are undefined, I get this error. It happens in a real scenario when I switch between 2 records, and component.js componentWillReceiveProps gets called

From component.js:

if (nextContents === this.lastDeltaChangeSet) {
        console.error(nextContents, this.lastDeltaChangeSet)
        throw new Error(
          'You are passing the `delta` object from the `onChange` event back ' +
            'as `value`. You most probably want `editor.getContents()` instead. ' +
            'See: https://github.com/zenoamaro/react-quill#using-deltas'
        )
      }

React-Quill version

1.3.3

貢獻者指南

技術棧
javascriptreact
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
React component lifecycleQuill delta understanding
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
45
研究方向
The issue is in component.js, where a check throws an error when both nextContents and this.lastDeltaChangeSet are undefined. The condition should handle the case where both are undefined (e.g., first render with no value). Look at the React component's componentWillReceiveProps method and the delta comparison logic. Consider adding a guard clause returning early when both are undefined to avoid the false positive.