area/platformgood first issue
倉庫指標
- Star
- (8,229 star)
- PR 合併指標
- (平均合併 17天 21小時) (30 天內合併 92 個 PR)
描述
- UniverseTaskBase.java, isServerAlive(), absent ybService.closeClient();
- Universe.java, getMasterLeader(), it is better to put closeClient() into the
finallyblock; - SetFlagInMemory.java, run(), closeClient() could be missed in case of any exceptions raised after getClient() and before closeClient();
- WaitForServerReady.java, run(), it is better to put closeClient() into the
finallyblock. Yes, it is almost impossible that ServerSubTaskBase.getHostPort() will throw an exception but actually this probability is not 0; - SessionController.java, getLogs(), Resource leak: 'reader' is never closed;
- SwamperHelper.java, writeTargetJsonFile(), the file may stay opened (in case of file.write of file.flush throws an exception);
- CertificateHelper.java, createRootCA(), Resource leak: 'certWriter' is never closed, Resource leak: 'keyWriter' is never closed; createClientCertificate(), 'clientCertWriter' and 'clientKeyWriter' are never closed (in case when storagePath != null).