yugabyte/yugabyte-db

[YCQL] Make it clear that transactions can't be enabled after table creation

Open

#1,048 建立於 2019年3月21日

在 GitHub 查看
 (3 留言) (0 反應) (0 負責人)C (1,003 fork)batch import
area/ycqlhelp wantedkind/enhancementpriority/medium

倉庫指標

Star
 (8,229 star)
PR 合併指標
 (平均合併 17天 21小時) (30 天內合併 92 個 PR)

描述

Jira Link: DB-4701

This is a YCQL issue. YSQL is not affected by this because all tables are transactional by default.

Right now, attempting to use ALTER TABLE to enable transactions given conflicting error messages complaining on the type only:

cqlsh> ALTER TABLE k.num WITH transactions.enabled = true;
SyntaxException: Invalid SQL Statement. syntax error, unexpected '.', expecting '='
ALTER TABLE k.num WITH transactions.enabled = true;
                                   ^
 (error -11)
cqlsh> ALTER TABLE k.num WITH transactions = '{"enabled": true}';
InvalidRequest: Error from server: code=2200 [Invalid query] message="Datatype Mismatch. Invalid value for option 'transactions'. Value must be a map
ALTER TABLE k.num WITH transactions = '{"enabled": true}';
                       ^^^^^^^^^^^^
 (error -201)"
cqlsh> ALTER TABLE k.num WITH transactions = {'enabled': true};
SyntaxException: Invalid SQL Statement. syntax error, unexpected '{'
ALTER TABLE k.num WITH transactions = {'enabled': true};
                                      ^
 (error -11)

So, error message asks user to use map value but complains about unexpected '{' if he does.

Proposal:

  • Any attempt to alter read-only property must report that clearly, e.g. cannot change read-only property
  • Transactions property being immutable should be explicitly mentioned in our docs

貢獻者指南