yarnpkg/yarn

`upgrade-interactive` always shows dependency installed via Git as outdated

Open

#4,896 建立於 2017年11月10日

在 GitHub 查看
 (8 留言) (2 反應) (1 負責人)JavaScript (41,514 star) (2,731 fork)batch import
cat-buggood first issuehelp wantedtriaged

描述

When running the following in an empty directory:

yarn init
yarn add https://github.com/timm-gs/pixelmatch
yarn upgrade-interactive

What is the current behavior?

Yarn shows the just added package as outdated. Same behavior on future attempts after upgrading. (Does not change yarn.lock)

What is the expected behavior?

I would expect yarn to know that the package / Git repo did not change and hence not offer to upgrade it.

Please mention your node.js, yarn and operating system version.

$ git --version
git version 2.15.0

$ node -v
v6.12.0

$ yarn -v
1.3.2

$ uname -a
Darwin MacBook-Pro.local 16.7.0 Darwin Kernel Version 16.7.0: Wed Oct  4 00:17:00 PDT 2017; root:xnu-3789.71.6~1/RELEASE_X86_64 x86_64

貢獻者指南

技術棧
javascriptnodejs
領域
cli
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
無
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
40
研究方向
Investigate the `upgrade interactive` command logic in the yarn codebase (likely in `src/cli/commands/upgrade interactive.js` or similar). The bug is that git installed dependencies always appear as outdated because the version comparison does not account for the git reference (commit SHA or branch). Focus on how the current version is determined for git dependencies and compare with the requested version. Check if there are any related tests or prior discussions in the issue comments (#4896) that provide additional context. The fix may involve comparing the resolved commit hash or using the git URI itself as version.