yarnpkg/yarn

An unexpected error occurred: "Commit hash required".

Open

#2,976 建立於 2017年3月23日

在 GitHub 查看
 (33 留言) (18 反應) (1 負責人)JavaScript (41,514 star) (2,731 fork)batch import
cat-bughelp wantedneeds-confirmationtriaged

描述

I've got a project, that has been running fine for months, where suddenly adding/installing eth-lightwallet fails during fetching packages with An unexpected error occurred: "Commit hash required".

Suddenly is defined as between March 21st, 9:51AM CET - March 22nd, 5:30PM CET with a commit that did not touch the package.json or lock files (just a css and html fix)

I've tried:

  • changing node version 7.7.4 and 7.7.1 (on 7.7.1 it worked before without question)
  • removing all caches, npm_modules, lockfiles
  • it fails both on a linux (alpine and debian) ci docker image, and on OSX
  • created a new project and added it. this worked, so it's my dependency set that breaks it
  • it appears to be related to bignumber.js in the dependencies, so tried a lot of different formats in https://github.com/roderik/eth-lightwallet.git
  • added if (!commit) console.log(_this2) to my git-fetcher.js line 113 and installed using yarn add https://github.com/roderik/eth-lightwallet.git --verbose --network-concurrency 1 --force Result: https://gist.github.com/roderik/f5ff6abfcdcdb364f2a5327016317de0 and the error log, but this does not show a reason for the commit hash to be empty
  • it installs fine with npm, so it's my dependencies + yarn

I'm stumped and reverted to yarn install || npm i on my ci, but this is not really the way it's supposed to be.

貢獻者指南

技術棧
javascriptnodejs
領域
backendtooling
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
4
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
over 1 week
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
active
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
needs investigation
前置要求
Node.js basicsYarn internalsGit protocolDebugging JavaScript
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
20
研究方向
The bug occurs when installing eth lightwallet via Yarn, with 'Commit hash required' error. Debugging shows the issue is in git fetcher.js line 113 where commit hash is empty. Since npm installs fine, the root cause is in Yarn's git fetching logic. Investigate the git fetcher module, specifically how commit hash is resolved for dependencies. Look at the eth lightwallet package.json and its dependency bignumber.js. Consider whether Yarn's git fetching has a regression related to how it handles tags or branches vs. commits.