yarnpkg/yarn

Engines check broken for nightly builds

Open

#2,172 建立於 2016年12月7日

在 GitHub 查看
 (12 留言) (0 反應) (0 負責人)JavaScript (41,514 star) (2,731 fork)batch import
cat-bughelp wanted

描述

We have a package which has the following engines field:

"engines": {
  "node": ">=6.0.0",
  "yarn": ">=0.18.0",
  "npm": ">=4.0.0"
}

in package.json. As there is not yet a stable "msi" package for Windows users for installation we thought of installing the latest nightly. Unfortunately yarn does not seem to be happy with the installed version. Possibly this is because the version check is somehow flawed.

Output from installing:

yarn install v0.18.0-20161123.1451
[1/4] Resolving packages...
[2/4] Fetching packages...
error advanced-boilerplate@0.14.7: The engine "yarn" is incompatible with this module. Expected version ">=0.18.0".
error Found incompatible module
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

This seems to be a bug as v0.18.0-20161123.1451 should be successfully matched by >=0.18.0.

貢獻者指南

技術棧
javascriptnodejs
領域
cli
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
basic Node.js knowledgeunderstanding of semantic versioning
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
60
研究方向
Investigate the semver comparison logic in yarn's engine validation. Look at how the engine requirement string is parsed and compared to the installed yarn version. The issue is likely in the version comparison function where pre release tags (like ' 20161123.1451') are not handled correctly for the '>=' operator. Check the `semver` npm package usage in the codebase, particularly in files like `src/package.js` or `src/install.js`. Consider if the solution is to properly compare pre release versions by stripping the pre release suffix or using a semver library that supports pre release comparison.