xyflow/xyflow

useKeyPress doesn't track repeated combination keypresses until the entire combination is released

Open

#2,248 建立於 2022年6月28日

在 GitHub 查看
 (14 留言) (6 反應) (0 負責人)TypeScript (19,286 star) (1,282 fork)batch import
help wantedtopic:keys

描述

Describe the Bug

When using useKeyPress to track combinations of keys, for example Meta+z, repeated keypresses are not captured if you continue to hold down the Meta key.

Your Example Website or App

https://codesandbox.io/s/recursing-driscoll-stvwou?file=/src/App.js

Steps to Reproduce the Bug or Issue

When const comboPressed = useKeyPress("Meta+z");:

  • Press and hold Meta
  • Press and hold z
  • comboPressed is true
  • Release z
  • comboPressed is still true and so additional presses of z can't be detected
  • Release Meta
  • comboPressed is now false

The inverse does not have the same behaviour:

  • Press and hold z
  • Press and hold Meta
  • comboPressed is true
  • Release Meta
  • comboPressed is now false and so additional presses of z can be detected

Expected behavior

As a user I would expect that after I press Meta and z, and then continue to hold Meta but release z that the pressed state of useKeyPress("Meta+z") is false.

Screenshots or Videos

No response

Platform

  • OS: macOS
  • Browser: Chrome
  • Version: 103.0.5060.53

Additional context

No response

貢獻者指南

技術棧
reacttypescript
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
active
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Familiarity with React hooksUnderstanding of keyboard eventsKnowledge of useKeyPress
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
60
研究方向
Examine the useKeyPress hook in the source code, likely located in the packages/react/src directory. Review the comments on this issue for insights on the desired behavior and any proposed fixes. The key challenge is tracking the state of key combinations when one key is released early.