xtermjs/xterm.js

Search is not incremental

Open

#5,177 建立於 2024年10月3日

在 GitHub 查看
 (1 留言) (0 反應) (0 負責人)TypeScript (16,196 star) (1,574 fork)batch import
area/addon/searcharea/performancehelp wantedtype/bug

描述

See https://github.com/xtermjs/xterm.js/issues/5176 for context

All searches take the same amount of time when the latter ones should take much less time due to being incremental:

Test file:

test.txt

Image

貢獻者指南

技術棧
typescript
領域
frontendperformance
議題類型
performance
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
understanding of search algorithmsfamiliarity with xterm.js addons
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
40
研究方向
Refer to the linked issue #5176 for context. The search is implemented in the search addon of xterm.js. Investigate the existing search implementation (likely in src/addons/search/) to understand why each search iteration is not incremental. Look for opportunities to memoize or cache results from previous searches to reduce time for subsequent searches.
Search is not incremental · xtermjs/xterm.js#5177 | Good First Issue