xtermjs/xterm.js

Search is too slow

已關閉

#5,176 建立於 2024年10月3日

在 GitHub 查看貢獻者指南
 (34 則留言) (4 個反應) (0 位負責人)TypeScript (1,574 個分叉)batch import
area/addon/searcharea/performancehelp wantedtype/bug

倉庫指標

星標
 (16,196 顆星)
PR 合併指標
 (平均合併 2天 10小時) (30 天內合併 16 個 PR)

描述

Currently the search addon limits itself to 1000 highlights by default. Contrast this to monaco's 20000 results before it gives up highlighting. When we increase our limit to 20000 the search itself ends up blocking the renderer pretty significantly.

Here is a profile using my i7-12700KF 3.61 GHz:

test file test.txt

Image

Image

Note that the search is also not incremental, so all successive searches take the same amount of time even for non-regex searches. https://github.com/xtermjs/xterm.js/issues/5177

VS Code issue: https://github.com/microsoft/vscode/issues/230365

貢獻者指南

研究方向
Investigate the search addon in xterm.js (likely in addons/search/). The issue shows that increasing the highlight limit causes renderer blocking; profile the search function to identify bottlenecks. Consider implementing incremental search to avoid re searching non regex queries (see linked issue #5177). Evaluate using a web worker to offload search computation. The test file provided can be used to reproduce the slowdown.
技術棧
typescript
領域
frontendperformance
議題類型
效能
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
半天
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
活躍
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
大致清晰
前置要求
Familiarity with xterm.js search addonBasic profiling skills
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
60