xtermjs/xterm.js

Issue in Linkifier2._removeIntersectingLinks

Open

#4,296 建立於 2022年12月8日

在 GitHub 查看
 (0 留言) (0 反應) (0 負責人)TypeScript (16,196 star) (1,574 fork)batch import
area/linkshelp wantedtype/bug

描述

Coming from https://github.com/xtermjs/xterm.js/pull/4288.

There is an issue with the private method Linkifier2._removeIntersectingLinks not correctly respecting multiple wrapped links in one merged line, which leads to wrong removal of later links.

On a first look it seems the method does not account y-progression, thus later links are mistaken as overlapping from their column position only.

貢獻者指南

技術棧
typescript
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
understanding of xterm.js linkifier architecture
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
30
研究方向
Examine the private method ` removeIntersectingLinks` in `Linkifier2.ts`. The issue indicates it fails to account for y progression when multiple wrapped links exist in a merged line. Check the linked PR #4288 for additional context and potential partial fix. The fix likely involves adjusting the intersection logic to compare both row and column positions rather than just column.