xtermjs/xterm.js

Issue in Linkifier2._removeIntersectingLinks

開放

#4,296 建立於 2022年12月8日

 (0 則留言) (0 個反應) (0 位負責人)TypeScript (1,574 個分叉)batch import
area/linkshelp wantedtype/bug

倉庫指標

星標
 (16,196 顆星)
PR 合併指標
 (平均合併 2天 10小時) (30 天內合併 16 個 PR)

描述

Coming from https://github.com/xtermjs/xterm.js/pull/4288.

There is an issue with the private method Linkifier2._removeIntersectingLinks not correctly respecting multiple wrapped links in one merged line, which leads to wrong removal of later links.

On a first look it seems the method does not account y-progression, thus later links are mistaken as overlapping from their column position only.

貢獻者指南