xtermjs/xterm.js

Auto fit addon doesn't work when parent element uses border-box

Open

#1,283 建立於 2018年2月12日

在 GitHub 查看
 (4 留言) (0 反應) (1 負責人)TypeScript (1,574 fork)batch import
area/addon/fitgood first issuehelp wantedtype/bug

倉庫指標

Star
 (16,196 star)
PR 合併指標
 (平均合併 2天 10小時) (30 天內合併 16 個 PR)

描述

The calculations for height and width of the parent in the auto fit plugin are incorrect when the parent element uses box-sizing: border-box. This is because the computed height includes the padding but the content does not.

The right implementation might be to get the client height of the parent element using gBCR and then subtract the parent padding.

/CC @taion

貢獻者指南