xi-editor/xi-editor

`Cmd-Z` should move the cursor to the point where the undo happens

Open

#765 建立於 2018年7月26日

在 GitHub 查看
 (7 留言) (3 反應) (0 負責人)Rust (19,842 star) (708 fork)batch import
enhancementhacktoberfesthelp wantedux

描述

Related issue https://github.com/google/xi-mac/issues/233

I gave the xi-mac frontend a try and found a small usability issue. When editing a long file (more than one scroll page), moving the cursor, and undoing the edit, the cursor doesn't move to the point where the undo happens.

Steps to reproduce:

  1. Open a long file
  2. Write something on the top of the file
  3. Scroll down and click somewhere so the cursor moves.
  4. Press Cmd-Z

What happens:

Text written in step 2 gets undoed, but there's no visual feedback. The cursor stays where it is.

What should happen:

The cursor and the scroll move to where the undo is happening.

Commits where it happens:

xi-mac: f5ee18b6ae0304efd45e8c33f0782550a86398e6 xi-editor: a417a3afb0b13dba09b44c9b93ec92cc6cb09ddd

Cheers.

貢獻者指南

技術棧
rustswift
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
basic Rustxi editor architectureundo system
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
45
研究方向
Investigate the undo handling in both xi editor backend and xi mac frontend. The issue relates to cursor position not being restored after undo. Look at how undo events are communicated from the backend to the frontend, and how the frontend updates cursor position. References: related issue #233 and commits f5ee18b in xi mac, a417a3af in xi editor.