xgfe/react-native-datepicker

Please put example code in sub directory

Open

#81 建立於 2017年2月9日

在 GitHub 查看
 (2 留言) (2 反應) (0 負責人)JavaScript (2,109 star) (737 fork)batch import
enhancementhelp wanted

描述

Hi, thanks for the great work. When I initially saw your codebase, I thought this was a React Native bridge module, but then came to understand it was a JS-only package. This is because I saw the android and ios directories. Also I was confused at index.ios.js and index.android.js files.

Typically in a RN library you put example code in a sub directory called Example or whatever. This will eliminate any confusion. If you need help, let me know and I'll create a PR for it

貢獻者指南

技術棧
react nativejavascriptandroidios
領域
mobile
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Familiarity with React Native project structureBasic knowledge of file organization
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
90
研究方向
First, examine the repository's root directory structure to locate existing example files (e.g., index.ios.js, index.android.js) and the android/ and ios/ directories. Then create an 'Example' subdirectory and move those files into it. Update any import paths within the moved files to reflect the new location. Also check the README or other documentation for references to the example code and update those paths accordingly. Ensure the example still works after the move.