xamarin/Xamarin.Forms

[Bug] Attached Collection Property return the property for all views and not just the one that is calling

Open

#9,151 建立於 2020年1月10日

在 GitHub 查看
 (2 留言) (0 反應) (0 負責人)C# (5,644 star) (1,926 fork)batch import
a/binding ⛓e/3 :clock3:help wantedinactivet/bug :bug:up-for-grabs

描述

Description

When having Collection like IList as an attached property, GetValue return the value for all views that has this property instead of return just the property related to the view that is calling GetValue.

Steps to Reproduce

  1. Run the sample.
  2. Click on the button that will execute code to get the properties to different views.

Expected Behavior

Method return property related only to itself.

Actual Behavior

view.GetValue return properties to all views that has it.

Basic Information

  • Version with issue: Xamarin.Forms (4.4.0.991265)

Reproduction Link

Sample with Issue

貢獻者指南

技術棧
csharp
領域
mobile
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
C#Xamarin.Forms attached properties
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
45
研究方向
Investigate the attached property implementation in Xamarin.Forms. The issue is that GetValue returns the same collection for all views when it should be per view. Look at how attached properties are stored and retrieved, particularly for IList types. Examine the sample repository at https://github.com/MathewLC/AttachedPropertyIssue for reproduction. Check if there is a known root cause in the Xamarin.Forms source code, e.g., in BindableObject or AttachedCollectionProperty classes.