winstonjs/winston

File logging reconfiguration issue (Error: write after end)

Open

#1,573 建立於 2019年1月23日

在 GitHub 查看
 (34 留言) (18 反應) (0 負責人)JavaScript (1,789 fork)batch import
BugGood First IssueHelp WantedImportant

倉庫指標

Star
 (21,967 star)
PR 合併指標
 (平均合併 68天 4小時) (30 天內合併 9 個 PR)

描述

Please tell us about your environment:

  • winston version?
    • winston@2
    • [ X] winston@3
  • _node -v outputs:_v10.15.0
  • _Operating System?_Windows 10
  • _Language? JavaScript (pure Node)

What is the problem?

When logger is reconfigured, the open streams are destroyed and winston tries to write to an already destroyed stream.

I created a really simple playground to replicate it (less than 10 lines of actual code): https://github.com/peterbakonyi05/winston-log-rotate-reconfiguration-issue/blob/master/index.js

What do you expect to happen instead?

winston creates a new stream and handles reconfiguration.

Note

Alternatively, instead of reconfiguring winston a new instance can be created, in case someone else has the same issue. Just call .close on the old instance and create a new from scratch.

貢獻者指南