winstonjs/winston

File logging reconfiguration issue (Error: write after end)

Open

#1,573 建立於 2019年1月23日

在 GitHub 查看
 (33 留言) (18 反應) (0 負責人)JavaScript (21,967 star) (1,789 fork)batch import
BugGood First IssueHelp WantedImportant

描述

Please tell us about your environment:

  • winston version?
    • winston@2
    • [ X] winston@3
  • _node -v outputs:_v10.15.0
  • _Operating System?_Windows 10
  • _Language? JavaScript (pure Node)

What is the problem?

When logger is reconfigured, the open streams are destroyed and winston tries to write to an already destroyed stream.

I created a really simple playground to replicate it (less than 10 lines of actual code): https://github.com/peterbakonyi05/winston-log-rotate-reconfiguration-issue/blob/master/index.js

What do you expect to happen instead?

winston creates a new stream and handles reconfiguration.

Note

Alternatively, instead of reconfiguring winston a new instance can be created, in case someone else has the same issue. Just call .close on the old instance and create a new from scratch.

貢獻者指南

技術棧
nodejsjavascript
領域
backend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Basic Node.js knowledgeUnderstanding of streams
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
40
研究方向
The issue describes a bug where reconfiguring a winston logger causes a 'write after end' error because open streams are destroyed. The reproduction is at https://github.com/peterbakonyi05/winston log rotate reconfiguration issue/blob/master/index.js. To fix this, investigate winston's Logger.prototype.configure method in the lib/winston/logger.js file and how it handles stream cleanup and reinitialization. The discussion in the issue may contain additional insights.