winstonjs/winston

Custom log levels can be silent unless level is also specified

Open

#1,491 建立於 2018年10月3日

在 GitHub 查看
 (6 留言) (0 反應) (0 負責人)JavaScript (21,967 star) (1,789 fork)batch import
BugGood First IssueHelp Wanted

描述

It is easy to write the following code and not realize that one has made a mistake:

const logger = winston.createLogger({
  levels: { eeny: 0, meeny: 1, miney: 2, moe: 3},
  transports: [
    new winston.transports.Console(),
  ]
});

logger.meeny('catch a tiger by the toe'); // never hollers

This could be addressed by the following check in the Logger constructor:

    if (!Object.keys(this.levels).includes(this.level)) {
      throw new Error(`Logger level ${this.level} is not in the levels: ${this.levels}`);
    }

I can open a PR if people agree it is worth fixing.

貢獻者指南

技術棧
javascript
領域
backenddeveloper experience
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
1
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
無
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
90
研究方向
Investigate the current implementation of the Logger constructor in the winston source code (likely in lib/winston/logger.js). Review the comments on this issue for any maintainer feedback or alternative approaches. Implement the validation check as suggested in the issue body, ensuring it throws an error if the specified level is not in the custom levels object.