Show line where hook that changed is used (feature request) · welldone-software/why-did-you-render#191

(3 留言) (4 反應) (0 負責人)JavaScript (10,560 star) (188 fork)batch import

enhancementgood first issuehelp wanted

描述

I currently have a very big hook, with dozens of useStates, lots of them have empty arrays which trigger unncesary re-renders. But I don't know which is the one doing it each time wdyr logs it's output. I get:

Re-rendered because of hook changes: 
[hook useState result]
...diff

When would be very useful for me is:

Re-rendered because of hook changes:
[hook useState result] (someRandomHook.ts:34)
...diff

Knowing which hook is changing would be useful, specially in nested hooks scenarios, for example I have a hook which uses a hook, and that internal one has state, but wdyr does not even specify which hook is that useState from (I guess react makes no distinction, it only cares about hook declaration order, so not sure how possible would this feature request be.)

貢獻者指南

技術棧: javascriptreact
領域: performancedeveloper experience
議題類型: feature
難度: 3
預計時間: 1-2 days
活動狀態: fresh
清晰度: mostly clear
前置要求: Understanding of React hooksFamiliarity with why did you render library source code
新手友善度: 50
研究方向: The issue requests to show the file and line number where a hook change originates. Start by examining the library's core files, particularly how it patches useState and other hooks (e.g., in src/monitorHooks.js or similar). Look for any existing stack trace collection or the ability to add Error().stack to capture the call site. Note that React does not naturally provide this info, but you could use a custom wrapper or monkey patch. Check if there are any comments or related PRs (none linked). A concrete approach: modify the hook patching to wrap the state setter with a function that captures the stack when called, then include that in the log output. Be aware of performance implications.