welldone-software/why-did-you-render

Wdyr ignores equality function in useSelector

Open

#190 建立於 2021年4月16日

在 GitHub 查看
 (3 留言) (1 反應) (0 負責人)JavaScript (10,560 star) (188 fork)batch import
Low prioritybuggood first issuehelp wanted

描述

When using wdyr I noticed that it reports unnecessary renders caused by useSelector with an equality function even though the equality function causes the render to be avoided. Looking at the code it looks like wdyr does not consider the result of the equality function.

An example:

useSelector(someSelector, (prev, next) => true);

貢獻者指南

技術棧
javascriptreact
領域
frontenddeveloper experience
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
React basicsunderstanding of useSelectorfamiliarity with wdyr
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
60
研究方向
Start by locating the code in the why did you render repository that tracks renders and detects unnecessary re renders. Specifically, look for how useSelector is patched and where the equality function is called. The issue suggests that the equality function's result is ignored. Investigate the patch logic in files like 'trackHooks.js' or similar. Check the existing comments and any linked PRs for additional context. Confirm that the equality function result is not considered and then implement a fix that respects it.
Wdyr ignores equality function in useSelector · welldone-software/why-did-you-render#190 | Good First Issue