webtorrent/webtorrent-desktop

Doesn't remember maximized window state

Open

#1,560 建立於 2019年3月29日

在 GitHub 查看
 (5 留言) (0 反應) (0 負責人)JavaScript (9,423 star) (1,055 fork)batch import
acceptedbuggood first contributionhelp wanted

描述

What version of WebTorrent Desktop? 0.20.0 (0.98.21) (64bit)

What operating system and version? Window 10 (v1809)

What did you do?

  • Open WebTorrent Desktop
  • Maximize the Window
  • Close (completely)
  • Re-open

What did you expect to happen? Remember the maximized window state after reopening

What actually happened? Opened in resized (default) window state

貢獻者指南

技術棧
javascriptelectron
領域
desktop
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
ElectronJavaScriptwindow management APIpersistent storage
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
60
研究方向
Investigate how window state (position, size, maximized) is currently saved and restored. Likely in main process, check 'main/index.js' or similar. Look for use of 'electron store' or custom JSON file for settings. The fix probably involves saving the maximized state in addition to bounds, and restoring it on app startup.
Doesn't remember maximized window state · webtorrent/webtorrent-desktop#1560 | Good First Issue