webtorrent/webtorrent-desktop

Consider autoHideMenuBar browser window option for Linux

Open

#1,134 建立於 2017年2月14日

在 GitHub 查看
 (3 留言) (0 反應) (0 負責人)JavaScript (9,423 star) (1,055 fork)batch import
acceptedenhancementgood first contributionhelp wanted

描述

Consider adding autoHideMenuBar to browser window on Linux, since the menu bar frequently looks terrible on non-Unity systems. It shouldn't have an effect on Ubuntu+Unity (the only Linux we officially support) since the menu bar isn't part of the window (it's like macOS).

This change needs to be tested.

貢獻者指南

技術棧
javascriptelectron
領域
desktop
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Electron basicsLinux OS for testing
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
65
研究方向
Locate where BrowserWindow is instantiated, likely in a main process file such as 'main.js'. Add the 'autoHideMenuBar' option (set to true) only for non Unity Linux systems, as Unity handles the menu bar separately. Verify that the change does not break Ubuntu+Unity by testing on that environment as well. Test on a Linux distribution without Unity (e.g., Fedora with GNOME) to ensure the menu bar is hidden.