web-platform-tests/wpt

WebSocketDaemon attempted spawn even when ws_doc_root is null

Open

#8,675 建立於 2017年12月13日

在 GitHub 查看
 (7 留言) (0 反應) (0 負責人)HTML (4,581 star) (2,898 fork)batch import
good first issueinfrapriority:backlog

描述

If ws_doc_root is null (default in config.default.json), server.py still attempts to spawn WebSocketDaemons, which then fail due to lack of config.

I'm pretty new to wpt so not sure if desired behavior in this case is to

a) Require that ws_doc_root be set b) If ws_doc_root is not set, skip spawning WebSocketDaemon c) Make WebSocketDaemon handle null and default config better

For now, I assuming b) but defer to experts in terms of how this should be handled.

貢獻者指南

技術棧
python
領域
backendtesting
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
Python basicswpt configuration
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
60
研究方向
Review the discussion in the issue comments (7 comments) to see if maintainers have indicated a preference among options (a), (b), or (c). If no clear direction, implement option (b) as suggested by the author: skip spawning WebSocketDaemon when ws doc root is null. Modify the relevant code in server.py to check for null before spawning. Update config.default.json if necessary to set a default value or document the behavior.