web-platform-tests/wpt

WebSocketDaemon attempted spawn even when ws_doc_root is null

Open

#8,675 建立於 2017年12月13日

在 GitHub 查看
 (7 留言) (0 反應) (0 負責人)HTML (2,898 fork)batch import
good first issueinfrapriority:backlog

倉庫指標

Star
 (4,581 star)
PR 合併指標
 (平均合併 6天 7小時) (30 天內合併 626 個 PR)

描述

If ws_doc_root is null (default in config.default.json), server.py still attempts to spawn WebSocketDaemons, which then fail due to lack of config.

I'm pretty new to wpt so not sure if desired behavior in this case is to

a) Require that ws_doc_root be set b) If ws_doc_root is not set, skip spawning WebSocketDaemon c) Make WebSocketDaemon handle null and default config better

For now, I assuming b) but defer to experts in terms of how this should be handled.

貢獻者指南