web-platform-tests/wpt

selectionchange testing TODOs

Open

#11,493 建立於 2018年6月13日

在 GitHub 查看
 (8 留言) (0 反應) (2 負責人)HTML (4,581 star) (2,898 fork)batch import
good first issueselectiontype:missing-coverage

描述

Over in PR #11491 I introduced a preliminary test for the selectionchange event.

Here is an initial pass at a TODO for more tests we should write for selectionchange:

  • test for invoking selectionchange without changing the selection
  • test that selection change does not fire in a document without a browsing context (i.e. document.implementation.createHTMLDocument)
  • test which document selectionchange fires when it is bound to in an iframe

While writing this initial coverage I encountered the following behavior which warrants further exploration in future tests/bugs/implementation patches. This area has a lot of compat issues to track down, so I think there may be a bunch of 'good first issues here':

  • When selectAllChildren runs, Firefox synchronously fires selectionchange, while Chrome appears to que a task.
  • selectAllChildren works on textareas in chrome and not firefox, while accessing textContent works in firefox but not chrome.
  • textarea innerText and textContent behave differently in Chrome and FF

貢獻者指南

技術棧
javascripthtml
領域
testing
議題類型
test
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-2 days
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
understanding of selection APIbasic JavaScriptbrowser compatibility concepts
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
55
研究方向
Start by reviewing PR #11491 to understand the initial test setup. Write tests for the three TODOs: selectionchange without changing selection, in document without browsing context, and in iframe. Investigate the noted behaviors (selectAllChildren, textarea differences) and determine expected behavior per spec. Look at existing tests in the selection directory for patterns.