vuejs/vue-router

The type definition of Route seems to be partially wrong

Open

#3,566 建立於 2021年6月9日

在 GitHub 查看
 (4 留言) (0 反應) (0 負責人)JavaScript (19,015 star) (5,092 fork)batch import
Typescriptcontribution welcomefixed on 4.xgood first issue

描述

Version

3.5.1

Reproduction link

https://github.com/vuejs/vue-router/blob/dev/types/router.d.ts#L203

Steps to reproduce

None, just the source code seems to be wrong.

What is expected?

The type definition of Route#query should be

query: Dictionary<string | null | (string | null)[]>

The current implementation cannot express this type of query

/path?foo#bar

as it doesn't have any value and it is not converted to an array.

What is actually happening?

https://github.com/vuejs/vue-router/blob/dev/types/router.d.ts#L203

The type definition of Route#query is

query: Dictionary<string | (string | null)[]>

貢獻者指南

技術棧
typescriptvue
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
basic TypeScript understanding
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
85
研究方向
The issue points to a specific line in types/router.d.ts (line 203) where the Route#query type is defined as Dictionary<string | (string | null)[]>. The expected change is to include string | null as an option for the dictionary value, making it Dictionary<string | null | (string | null)[]>. This is a simple type correction. No discussion or PRs are linked. The fix should be applied to the same file.