volta-cli/volta

Investigate VS Code Git Tools & Pre-commit

Open

#516 建立於 2019年8月5日

在 GitHub 查看
 (1 留言) (0 反應) (0 負責人)Rust (8,309 star) (189 fork)batch import
help wantedquestion

描述

If your project has a pre-commit hook that calls a Node command, and you use VS Code Git Tools to initiate a commit, Volta appears to be finding the default Node instead of the Node specified in package.json.

A possible cause of this is VS Code is somehow executing the Git commit with a cwd that is outside of the project, causing Volta to start in the wrong directory and not find the project-local settings. If possible, we should correctly handle this case, or worst provide some guidance for how to set up VS Code to get the expected behavior.

貢獻者指南

技術棧
rustnodejs
領域
toolingdeveloper experience
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
4
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
3-5 days
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
Familiarity with RustUnderstanding of VS Code Git Tools
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
25
研究方向
Investigate how Volta determines the current working directory when invoked by VS Code Git Tools, possibly in the launch or commit hook path. The issue suggests the cwd might be outside the project. Look at the Volta source code in the `src/` directory for functions that resolve Node versions, particularly around process environment and directory detection. Test with VS Code Git Tools to reproduce the bug. Consider adding a fallback or documentation for VS Code users.