volta-cli/volta

Use checksums for cached distributions

Open

#134 建立於 2018年8月27日

在 GitHub 查看
 (1 留言) (2 反應) (0 負責人)Rust (8,309 star) (189 fork)batch import
enhancementgood first issue

描述

NOTE: this issue predates this project's rename to Volta.

We should verify the checksums of the distributions downloaded by Notion, to:

  • verify the downloaded distro is correct, and
  • verify the cached distro is valid

Node

Node distributions have a corresponding sha256sum file at https://nodejs.org/dist/vx.y.z/SHASUMS256.txt (see https://github.com/nodejs/node#verifying-binaries).

We should download that checksum, and can verify it using the sha2 crate.

Yarn

Short-term, we will need to add checksums to https://github.com/notion-cli/yarn-releases, and verify those.

Long-term, we will probably get yarn from github (at https://github.com/yarnpkg/yarn/releases). But they don't include checksums with those releases, or through the API (e.g. https://api.github.com/repos/yarnpkg/yarn/releases/latest) – not sure what we can use for that.

貢獻者指南

技術棧
rust
領域
clideveloper experience
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-2 days
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Rust programmingSHA256 hashing
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
55
研究方向
Implement checksum verification for cached Node distributions by downloading the SHA256SUMS file from nodejs.org and using the sha2 crate to verify. For Yarn, create checksums for the repository at https://github.com/notion cli/yarn releases and verify those. Check the existing codebase for download logic and file caching, likely in src/ directory.
Use checksums for cached distributions · volta-cli/volta#134 | Good First Issue