vmware/pyvmomi

pyVmomi should never extend base or core types

Open

#69 建立於 2014年6月26日

在 GitHub 查看
 (0 留言) (0 反應) (0 負責人)Python (2,141 star) (807 fork)batch import
bughelp wantedhigh priority

描述

This VmomiSupport.py#L179 is considered extremely bad form in the Python community. Extension of core types ties the code to interpreter internals that may not be intended for exposure. This is akin to using a hidden API and should be avoided or at least isolated so that potential damage is easier to control.

Rewrite the code so that the class Link is not needed anymore or so that Link can operate without directly extending a core type.

貢獻者指南

技術棧
python
領域
backendapi
議題類型
refactor
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
understanding of Python metaclassesfamiliarity with pyvmomi codebase
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
20
研究方向
The issue points to VmomiSupport.py#L179 where the Link class extends a core type (e.g., dict or list). The goal is to refactor the Link class to not extend a core type. Investigate the current usage of Link in the codebase and consider using composition or a wrapper class. Look at how the core type extension is used elsewhere in the code to understand the impact. No comments or linked PRs exist, so the solution is open ended.