vmware/pyvmomi-community-samples

Do not swallow errors!

Open

#11 建立於 2014年5月21日

在 GitHub 查看
 (1 留言) (0 反應) (0 負責人)Python (972 star) (914 fork)batch import
enhancementhelp wanted

描述

https://github.com/vmware/pyvmomi-community-samples/blob/master/samples/create_random_marvel_vms.py#L195

In sample code, don't trap errors coming off of ...

si = connect.SmartConnect(

... instead just expose those to the CLI. We are attempting to make teaching samples here and too thoroughly swallowing or handling errors can make the samples harder to read and understand for programmers who are still learning.

貢獻者指南

技術棧
python
領域
documentation
議題類型
documentation
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
basic Python knowledge
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
65
研究方向
Start by examining the file `samples/create random marvel vms.py` around line 195 where `connect.SmartConnect` is called. Remove the error handling that swallows exceptions, allowing them to propagate to the CLI. Check if there are other samples with similar patterns.