viper-framework/viper

Rats modules using outdated crypto library

Open

#710 建立於 2018年10月14日

在 GitHub 查看
 (2 留言) (0 反應) (0 負責人)Python (1,527 star) (372 fork)batch import
help wanted

描述

There are several modules in the rats/ folder by @kevthehermit that are using a crypto library called pycrypto, mostly for AES and DES support. Unfortunately, this library hasn't been updated since 2014 and also has a vulnerable ElGamal implementation: https://nvd.nist.gov/vuln/detail/CVE-2018-6594

We should update these modules to make use of cryptography instead and drop pycrypto all together from our dependencies.

貢獻者指南

技術棧
python
領域
backendsecurity
議題類型
security
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-2 days
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Basic PythonFamiliarity with cryptography libraryAbility to write testsKnowledge of AES/DES
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
40
研究方向
Review the modules in the `rats/` directory that currently import from `pycrypto`. For each, identify the cryptographic operations (e.g., AES, DES) and replace them with equivalent functions from the `cryptography` library. Update the setup.py or requirements to remove `pycrypto` and add `cryptography`. Run existing tests and add new ones to verify the replacement works correctly. Check if any comments or previous attempts exist in the issue thread.