videojs/video.js
在 GitHub 查看Volume/Mute State Not Preserved Switching Between HTML5 and Flash Techs
Open
#2,066 建立於 2015年4月23日
confirmedgood first issuepinnedunclaimed
倉庫指標
- Star
- (39,742 star)
- PR 合併指標
- (平均合併 111天 10小時) (30 天內合併 3 個 PR)
描述
I see 2 problems with volume/mute handling in videojs:
- Html5 and Flash tech are inconsistent handling volume and muted. Html5 maintains 2 separate variables to hold the value for
volume()andmuted(). Flash on the other hand setsvolume = 0whenmuted(true)is called. My guess is Html5 is the proper implementation desired. - The state stored for
volume()andmuted()are delegated to the Tech. Switching between Techs causes volume and muted states to be lost between the timeunloadTechandloadTechis called. A simple hack is to add a couple lines insideloadTechto save the state ofmutedandvolumeand then reapply those states inside thetechReadyfunction. Going forward, I feel the Player core should hold these states.
I'm working off a modified version of v4.12.5