victorb/trymodule

Fix exec call to remove cache folder

Open

#15 建立於 2016年3月29日

在 GitHub 查看
 (0 留言) (0 反應) (0 負責人)JavaScript (31 fork)github user discovery
enhancementhelp wanted

倉庫指標

Star
 (1,133 star)
PR 合併指標
 (PR 指標待抓取)

描述

https://github.com/VictorBjelkholm/trymodule/blob/2030806d790213d426456959fdc7a69773a4c6f7/index.js#L59

Oh noes. Please don't. Never do string concat for commands, use execFile instead. Never pass environment variables directly to rm without sanitation, better yet, never spawn rm. Use a JS tools, like rimraf or even better del.

From: https://github.com/sindresorhus/awesome-nodejs/pull/477#event-606502245

貢獻者指南