vercel/release

Can't release if there's only 1 commit since last tag

Open

#93 建立於 2017年6月30日

在 GitHub 查看
 (3 留言) (2 反應) (0 負責人)JavaScript (3,534 star) (145 fork)batch import
bughelp wanted

描述

I end up with the error Error! No changes happened since the last release. if I have only 1 commit since the last tag.

Seems like the following code might be the issue https://github.com/zeit/release/blob/master/lib/commits.js#L22

  if (commit.hash === release.hash) {
    return
  }

貢獻者指南

技術棧
javascriptnodejs
領域
toolingrelease
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Node.jsbasic git knowledge
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
85
研究方向
The issue is in lib/commits.js at line 22 where the code returns early if the commit hash matches the release hash. This causes a failure when there is only one commit since the last tag. To fix, the logic should be adjusted to handle the single commit case, possibly by not returning or by checking the number of commits. There are no linked PRs, so the solution is open for implementation. The maintainer has not commented on the issue, so the scope is defined by the reported bug.