vercel/next.js

ISG with GIP in _app overrides cache-control of ISG page

Open

#14,244 建立於 2020年6月16日

在 GitHub 查看
 (3 留言) (0 反應) (1 負責人)JavaScript (139,471 star) (31,066 fork)batch import
Pages Routergood first issuetype: next

描述

Bug report

When using the unstable_revalidate param with ISG, a header set by _app should never win.

Additional context

From @lfades:

Update: this is currently not the case, SSG finishes the request before it gets to _app.

the custom _app in the Next.js site was setting a header, but that causes an error because the request was sent, this happens in production and with next start, but in dev you don't get any error.

貢獻者指南

技術棧
nextjsreactjavascripttypescript
領域
full stack
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-2 days
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
blocked
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
Next.jsISGgetInitialPropscache control
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
30
研究方向
Investigate how Next.js handles cache control headers when using ISG with getInitialProps in app. Look at the source files related to ISG, such as next server and router. A minimal reproduction would help confirm the issue. Check if there are existing tests for this scenario in the Next.js test suite.