vercel/hyper

Request: add "tab:close" shortcut

Open

#3,548 建立於 2019年3月28日

在 GitHub 查看
 (8 留言) (0 反應) (0 負責人)TypeScript (44,582 star) (3,558 fork)batch import
help wanted🎨 Type: Enhancement

描述

Per https://github.com/zeit/hyper/blob/master/app/keymaps/win32.json, there is no shortcut to close tabs.

Adding "tab:close": "ctrl+w", to keymaps doesn't work.

Could you please add a "tab: close" shortcut?

Hyper 3 Canary 8, Windows 10.0.18860.0, can't see this reported in any other issue.

貢獻者指南

技術棧
typescriptjavascriptelectron
領域
desktop
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Familiarity with Hyper terminalBasic knowledge of Electron keyboard shortcutsUnderstanding of JSON keymaps
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
65
研究方向
Investigate how keyboard shortcuts are defined and registered in Hyper. Start by examining the keymaps file at `app/keymaps/win32.json` and similar files for other platforms. Look for the code that parses these keymaps and binds shortcuts, likely in the main process. The user reported that manually adding the entry did not work, so there may be a missing handler or conflict that needs to be resolved.
Request: add "tab:close" shortcut · vercel/hyper#3548 | Good First Issue