prometheus_exporter does not support Content-Encoding · vectordotdev/vector#19962

(8 留言) (1 反應) (0 負責人)Rust (21,837 star) (2,126 fork)batch import

good first issuesink: prometheus_exportertype: feature

描述

A note for the community

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

Use Cases

Vector's prometheus_exporter does not appear to support gzip content-encoding:

$ curl -v --compressed http://localhost:9598/metrics
*   Trying [::1]:9598...
* Connected to localhost (::1) port 9598
> GET /metrics HTTP/1.1
> Host: localhost:9598
> User-Agent: curl/8.4.0
> Accept: */*
> Accept-Encoding: deflate, gzip, br, zstd
>
< HTTP/1.1 200 OK
< content-type: text/plain; version=0.0.4
< content-length: 103854
< date: Tue, 27 Feb 2024 20:42:05 GMT
<
# HELP vector_adaptive_concurrency_averaged_rtt adaptive_concurrency_averaged_rtt
...

Whereas other Promtheus exporters such as node_exporter automagically do this:

$ curl -I --compressed -v http://localhost:9100/metrics
*   Trying [::1]:9100...
* Connected to localhost (::1) port 9100
> HEAD /metrics HTTP/1.1
> Host: localhost:9100
> User-Agent: curl/8.4.0
> Accept: */*
> Accept-Encoding: deflate, gzip, br, zstd
>
< HTTP/1.1 200 OK
HTTP/1.1 200 OK
< Content-Encoding: gzip
Content-Encoding: gzip
< Content-Type: text/plain; version=0.0.4; charset=utf-8
Content-Type: text/plain; version=0.0.4; charset=utf-8
< Date: Tue, 27 Feb 2024 20:43:28 GMT
Date: Tue, 27 Feb 2024 20:43:28 GMT

I have many metrics on the same key / labels - so would be beneficial to have this compressed at the network-layer.

Attempted Solutions

No response

Proposal

No response

References

No response

Version

0.34.1

貢獻者指南

技術棧: rust
領域: backendperformance
議題類型: feature
難度: 3
預計時間: half day
活動狀態: fresh
清晰度: clear
前置要求: RustHTTP compressionVector codebase familiarity
新手友善度: 50
研究方向: Start by examining the prometheus exporter source code in Vector, likely under src/sources/prometheus/ or src/sinks/prometheus/. Look for the HTTP response handler that serves /metrics. The issue requires adding support for gzip compression based on the Accept Encoding request header. Check if Vector already uses a compression library like flate2 or async compression. Implement middleware or modify the response to set Content Encoding header and compress the body when the client supports gzip. Refer to existing patterns like the node exporter's approach or other HTTP endpoints in Vector that already support compression.