valyala/fasthttp

How to integrate fasthttp client with opentracing gracefully

Open

#775 建立於 2020年4月7日

在 GitHub 查看
 (3 留言) (0 反應) (0 負責人)Go (21,741 star) (1,755 fork)batch import
help wanted

描述

net/http expose RoundTrip so it can integrate with opentracing by overwrite the RoundTrip function. while fasthttp client don't implement such interface and do not provide middleware. The only way to integrate with opentracing is overwrite all method of fasthttp client, but it is not graceful.

貢獻者指南

技術棧
go
領域
backendobservability
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-2 days
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Go programmingKnowledge of OpenTracing conceptsFamiliarity with fasthttp client
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
45
研究方向
The issue requests a graceful way to integrate OpenTracing with the fasthttp client, similar to net/http's RoundTrip mechanism. Research the net/http opentracing integration in opentracing contrib/go stdlib (nethttp/client.go) to understand the approach. Examine fasthttp's client source code (client.go) to identify where a middleware or interceptor could be added without compromising performance. Consider designing a client wrapper or method level hooks. Discuss the proposed design with maintainers in the issue comments.
How to integrate fasthttp client with opentracing gracefully · valyala/fasthttp#775 | Good First Issue