valyala/fasthttp

add a IP addr in this error for locating issues faster?

Open

#732 建立於 2020年1月19日

在 GitHub 查看
 (4 留言) (0 反應) (0 負責人)Go (21,741 star) (1,755 fork)batch import
help wanted

描述

https://github.com/valyala/fasthttp/blob/03813ae4bce8b5984118f62d5f017da3e87c9189/tcpdialer.go#L365

usually, dialing a host, that resovle to mullti ips. and If include the IP information in this ErrDialTimeout, we can know which server is the problem faster.

貢獻者指南

技術棧
go
領域
backenddeveloper experience
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
1
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
basic Go knowledgefamiliarity with fasthttp tcpdialer.go
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
90
研究方向
Locate the file tcpdialer.go at line 365 in the fasthttp repository. The ErrDialTimeout error message currently includes the host but not the IP address that was being dialed. Modify the error to include the resolved IP address (e.g., add a parameter for the IP). Check the DialTimeout function to see how it gets the addresses and pass the IP to the error string. No linked PRs or assignees found; this issue is open for contribution.