valyala/fasthttp

Recommendation on cleaning of HostClient.

Open

#726 建立於 2020年1月12日

在 GitHub 查看
 (2 留言) (0 反應) (0 負責人)Go (21,741 star) (1,755 fork)batch import
help wantedquestion

描述

As of now the only way to override Host header is to use HostClient as per Issue 318. This means we have to manage reusing/cleanup of HostClients ourselves which fasthttp.Client provided out of the box.

We will be writing something very similar to fasthttp.Client to handle this. Is it ok to remove the HostClient if it is not being used from more than MaxIdleConnDuration*2 or something, as we are sure all goroutines for individual connection cleaning would have run? We don't have access to connsCount as it is an unexported field and was modified to use connsCount instead of time.

if t.Sub(v.LastUseTime()) > (MaxIdleConnDuration*2) {
				delete(m, k)
			}

If not, what is the recommendation here?

貢獻者指南

技術棧
go
領域
backendapi
議題類型
research
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
Understanding of GoFamiliarity with fasthttp client internals
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
30
研究方向
Investigate the fasthttp client code, specifically client.go lines 450-452 and 463-465, and the commit aebec409b. Determine if using MaxIdleConnDuration*2 as a timeout for removing unused HostClients is safe, considering goroutine cleanup timing. Also consider if there is a need to expose connsCount or provide a dedicated cleanup method for HostClients.
Recommendation on cleaning of HostClient. · valyala/fasthttp#726 | Good First Issue