valyala/fasthttp

It is not safe to read all stream body to memory without a max size limit.

Open

#1,765 建立於 2024年4月23日

在 GitHub 查看
 (8 留言) (0 反應) (0 負責人)Go (21,741 star) (1,755 fork)batch import
help wanted

描述

https://github.com/valyala/fasthttp/blob/57b9352ad1cc93a0aaaa72b2130e03ace8a5b118/http.go#L427 I think it would be safe to stop reading the request body into memory and return an error when it exceeds the maximum request body size. Otherwise, it may lead to an out-of-memory (OOM) error when the request body is too large.

貢獻者指南

技術棧
go
領域
backendsecurity
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Go basicsHTTP server internals
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
45
研究方向
The issue points to line 427 in http.go where the entire request body is read into memory without a size limit. To fix, add a check for a maximum request body size before reading, preferably using a configurable limit (e.g., MaxRequestBodySize). When exceeded, the read should stop and return an error, likely with a 413 status code. Ensure integration with the existing fasthttp request handling pipeline and consider any existing size settings.
It is not safe to read all stream body to memory without a max size limit. · valyala/fasthttp#1765 | Good First Issue